Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37295 )
Change subject: mb/lenovo/t520: Switch to overridetree ......................................................................
Patch Set 7: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/37295/7/src/mainboard/lenovo/t520/K... File src/mainboard/lenovo/t520/Kconfig:
https://review.coreboot.org/c/coreboot/+/37295/7/src/mainboard/lenovo/t520/K... PS7, Line 56: default "variants/$(CONFIG_VARIANT_DIR)/overridetree.cb" Isn't this the default already?
https://review.coreboot.org/c/coreboot/+/37295/7/src/mainboard/lenovo/t520/d... File src/mainboard/lenovo/t520/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37295/7/src/mainboard/lenovo/t520/d... PS7, Line 93: USB 3.0 only W520 I'd drop this since it's already on the overridetree
https://review.coreboot.org/c/coreboot/+/37295/7/src/mainboard/lenovo/t520/v... File src/mainboard/lenovo/t520/variants/w520/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37295/7/src/mainboard/lenovo/t520/v... PS7, Line 4: only W520 I think you can drop this part of the comment