Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36716/10/src/mainboard/google/hatch...
File src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36716/10/src/mainboard/google/hatch...
PS10, Line 139: 12000,
I'm still curious about this value. I thought the TDP was supposed to be contained within the PL1 range (i.e., PL1 is typically set the same as TDP). But Akemi still has the TDP_PL1_override set to 15 Watts (overridetree.cb:2), so I'm just confused as to what this means, with the two values seemingly conflicting.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36716
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0e6d93e1fc0c684e067d1450eb119a53cfefaed
Gerrit-Change-Number: 36716
Gerrit-PatchSet: 10
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marx Wang
marx.wang@intel.corp-partner.google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 Nov 2019 04:14:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment