Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34397 )
Change subject: mb/google/kohaku: Update DPTF parameters ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34397/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34397/1//COMMIT_MSG@10 PS1, Line 10: perpose purpose
https://review.coreboot.org/c/coreboot/+/34397/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/34397/1/src/mainboard/google/hatch/... PS1, Line 64: 51000 Shouldn't this match tdp_pl2_override? That seems to be set to 52W and not 51W here: https://review.coreboot.org/c/coreboot/+/34398/1/src/mainboard/google/hatch/...
Also, can you please squash the two changes into one CL? They should be really going in together.