Attention is currently required from: Arthur Heymans, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54730 )
Change subject: sb/intel/common: Build smbus.c in every stage
......................................................................
Patch Set 1: Code-Review-2
(1 comment)
Patchset:
PS1:
SMBus accesses from within SMM are not a good idea...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54730
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id67f31d28b0566bfe73f48af9f87375f47cb4fe1
Gerrit-Change-Number: 54730
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 28 May 2021 11:38:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment