Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36431 )
Change subject: soc/intel/icelake: Remove redundant dependency check in cpu.c ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36431/2/src/soc/intel/icelake/bootb... File src/soc/intel/icelake/bootblock/cpu.c:
https://review.coreboot.org/c/coreboot/+/36431/2/src/soc/intel/icelake/bootb... PS2, Line 23: if (CONFIG(BOOT_DEVICE_MEMORY_MAPPED))
I don't think this is correct. The call below *assumes* spi flash, but the check is removed for it. […]
Agree but as boot from block device is not POR on core platform hence can't we assume that core platforms do have SPI mapped memory access enable (unlike APL/GLK) and this is not common code so we can make the assumption specific for ICL right ?