Attention is currently required from: Angel Pons, Intel coreboot Reviewers.
Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/87388?usp=email )
Change subject: nb/intel/sandybridge: Add CFR objects for existing options
......................................................................
Patch Set 3:
(1 comment)
File src/northbridge/intel/sandybridge/cfr.h:
https://review.coreboot.org/c/coreboot/+/87388/comment/9bff36ef_46f10479?usp... :
PS1, Line 20: /* Power state after power loss */
not sure what you mean here
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87388?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I892ffcc74d36a266697cbc7ea3c8880db6b67f44
Gerrit-Change-Number: 87388
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 21 Apr 2025 14:56:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com