Balázs Vinarz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation ......................................................................
Patch Set 29:
(4 comments)
Patch Set 29:
Patch Set 29:
Patch Set 28:
(2 comments)
do we need to list the unused devices? I checked all of them and the non-listed ones were really empty.
Yes, not to lose the knowledge of what is situated at these PCIe lanes, which could be useful. Also, please investigate a comment above
I changed the commit message according to: - ethernet is working (Kyoesti Maelkki helped me with the port enable hint) - IOMMU is still broken
https://review.coreboot.org/c/coreboot/+/30987/29//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/30987/29//COMMIT_MSG@30 PS29, Line 30: K
Please check two comments below, hopefully these "known problems" do not exist anymore.
Ack
https://review.coreboot.org/c/coreboot/+/30987/25/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/buildOpts.c:
https://review.coreboot.org/c/coreboot/+/30987/25/src/mainboard/asus/a88xm-e... PS25, Line 325: #
I remembered that onboard ethernet didn't work, so added to the "Known problems" of this change. […]
Done
https://review.coreboot.org/c/coreboot/+/30987/25/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/30987/25/src/mainboard/asus/a88xm-e... PS25, Line 29: d
Please could you test IOMMU again, on a freshly cloned latest coreboot and the latest revision of yo […]
Done
https://review.coreboot.org/c/coreboot/+/30987/25/src/mainboard/asus/a88xm-e... PS25, Line 33: end
Done.
Ack