Attention is currently required from: Jason Glenesk, ritul guru, Fred Reitberger, Felix Held.
Anand Vaikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74308 )
Change subject: mb/amd/mayan: Enable MXM PCIe slot
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4:
Addressed Fred's comments.
File src/mainboard/amd/mayan/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/74308/comment/dc2c56a3_2d88dfb2
PS3, Line 13: // MXM
This looks like the same change as in CB:74191 - it would probably be better to rebase this patch on […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74308
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I75d7ac488bb005751e6f674ab9a2fd99baad571b
Gerrit-Change-Number: 74308
Gerrit-PatchSet: 4
Gerrit-Owner: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 03 May 2023 05:55:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-MessageType: comment