build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45475 )
Change subject: cpu/x86/smm: Move smmstore entry to a common place ......................................................................
Patch Set 1:
(9 comments)
https://review.coreboot.org/c/coreboot/+/45475/1/src/drivers/smmstore/smi.c File src/drivers/smmstore/smi.c:
https://review.coreboot.org/c/coreboot/+/45475/1/src/drivers/smmstore/smi.c@... PS1, Line 92: if (get_save_state_reg(RAX, apmc_node, &ax, sizeof(ax))) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/1/src/drivers/smmstore/smi.c@... PS1, Line 92: if (get_save_state_reg(RAX, apmc_node, &ax, sizeof(ax))) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/amd/picasso/smihand... File src/soc/amd/picasso/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/amd/picasso/smihand... PS1, Line 77: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/amd/stoneyridge/smi... File src/soc/amd/stoneyridge/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/amd/stoneyridge/smi... PS1, Line 75: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/intel/baytrail/smih... File src/soc/intel/baytrail/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/intel/baytrail/smih... PS1, Line 298: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/intel/braswell/smih... File src/soc/intel/braswell/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/intel/braswell/smih... PS1, Line 275: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/intel/broadwell/smi... File src/soc/intel/broadwell/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/intel/broadwell/smi... PS1, Line 313: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/intel/common/block/... File src/soc/intel/common/block/smm/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/1/src/soc/intel/common/block/... PS1, Line 343: apmc_smmtore_handler(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45475/1/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45475/1/src/southbridge/intel/lynxp... PS1, Line 289: apmc_smmtore_handler(); code indent should use tabs where possible