Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38222 )
Change subject: soc/amd/stoneyridge: move to using smbus_host.h definitions
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38222/4/src/soc/amd/stoneyridge/smb...
File src/soc/amd/stoneyridge/smbus.c:
https://review.coreboot.org/c/coreboot/+/38222/4/src/soc/amd/stoneyridge/smb...
PS4, Line 28: return asf_read8(reg);
Inspecting the assembly it looked like the compiler is not able to do a good optimisation of this ev […]
The SMBus slave side code should not be required to know the base address, slave-side sources are not allowed to include platform-specific host-side headerfiles.
To be addressed at some later date when needs to support SMBus multiplexers is evaluated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38222
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic912b91daf79ecd2c276a383edcda563891cf643
Gerrit-Change-Number: 38222
Gerrit-PatchSet: 8
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 30 Jan 2020 09:54:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment