Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36186 )
Change subject: mb/mainboard/hatch: support Goodix touch panel for Akemi
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36186/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36186/1/src/mainboard/google/hatch/...
PS1, Line 105: 10
This needs to be 120 ms, according to the spec.
https://review.coreboot.org/c/coreboot/+/36186/1/src/mainboard/google/hatch/...
PS1, Line 106: register "generic.enable_gpio" =
: "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)"
You might want to add enable_delay_ms here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36186
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I83060f31d4d22c9be05bba119816c6aa66e4126c
Gerrit-Change-Number: 36186
Gerrit-PatchSet: 1
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 21 Oct 2019 16:33:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment