build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32934 )
Change subject: soc/amd/common: Add errors for invalid AcpiMmio access ......................................................................
Patch Set 4:
(7 comments)
https://review.coreboot.org/#/c/32934/4/src/soc/amd/common/block/acpimmio/mm... File src/soc/amd/common/block/acpimmio/mmio_util.c:
https://review.coreboot.org/#/c/32934/4/src/soc/amd/common/block/acpimmio/mm... PS4, Line 139: /* pm2 read/write - access registers at 0xfed80400 - currently unused by any soc */ line over 80 characters
https://review.coreboot.org/#/c/32934/4/src/soc/amd/common/block/acpimmio/mm... PS4, Line 182: /* cmosram read/write - access registers at 0xfed80600 - currently unused by any soc */ line over 80 characters
https://review.coreboot.org/#/c/32934/4/src/soc/amd/common/block/acpimmio/mm... PS4, Line 186: /* cmos read/write - access registers at 0xfed80700 - currently unused by any soc */ line over 80 characters
https://review.coreboot.org/#/c/32934/4/src/soc/amd/common/block/acpimmio/mm... PS4, Line 272: /* wdt read/write - access registers at 0xfed80b00 - not currently used by any soc */ line over 80 characters
https://review.coreboot.org/#/c/32934/4/src/soc/amd/common/block/acpimmio/mm... PS4, Line 276: /* hpet read/write - access registers at 0xfed80c00 - not currently used by any soc */ line over 80 characters
https://review.coreboot.org/#/c/32934/4/src/soc/amd/common/block/acpimmio/mm... PS4, Line 348: /* dpvga read/write - access registers at 0xfed81400 - not currently used by any soc */ line over 80 characters
https://review.coreboot.org/#/c/32934/4/src/soc/amd/common/block/acpimmio/mm... PS4, Line 398: /* acdc_tmr read/write - access registers at 0xfed81d00 - not currently used by any soc */ line over 80 characters