[coreboot-gerrit] [S] Change in coreboot[master]: soc/amd/mendocino: Force resets to be cold

[Tim Van Patten (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Fred Reitberger, Felix Held.

Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72486 )

Change subject: soc/amd/mendocino: Force resets to be cold
......................................................................

Patch Set 3:

(1 comment)

File src/soc/amd/mendocino/fch.c:

https://review.coreboot.org/c/coreboot/+/72486/comment/daf65d4a_8a319e9a 
PS3, Line 131: 	pm_write16(PWR_RESET_CFG, pm_read16(PWR_RESET_CFG) | TOGGLE_ALL_PWR_GOOD);
> s/host/OS/

It sounds like cold resets are at least somewhat broken without this too, since it's issuing that call in `do_cold_reset()`.

It's not necessary, but unless someone objects (and you have time) I do think it's worth splitting this CL up to fix the issues separately:

1. Add `fch_init_resets()`, this fixes `do_cold_reset()`.
2. Call `do_cold_reset()` from `do_warm_reset()`, since warm resets are not working/supported.