Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34388 )
Change subject: google/nocturne: Add MKBP events as a wake source
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34388/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34388/1//COMMIT_MSG@7
PS1, Line 7: google/nocturne: Add MKBP events as a wake source.
Done. […]
I think this is a pretty common guide for commit messages. I've read it in a few different recommendations for formatting commits.
"Trailing punctuation is unnecessary in subject lines. Besides, space is precious when you’re trying to keep them [short]."
https://chris.beams.io/posts/git-commit/
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34388
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6aff4d38051c939257533229fd0085e42c01d02f
Gerrit-Change-Number: 34388
Gerrit-PatchSet: 2
Gerrit-Owner: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 19 Jul 2019 16:43:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aseda Aboagye
aaboagye@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment