Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34972 )
Change subject: lib/bootblock: Add simplified entry with basetime ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34972/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34972/3//COMMIT_MSG@11 PS3, Line 11: with calls to timestamp_add() gets removed from bootblock.
Are you sure this works that way (did you check the assembly output)? I don't think the compiler wil […]
Here's the assembly.
ffff5700 <bootblock_main_with_timestamp.constprop.1>: ffff5700: mov $0xfef05000,%ecx ffff5705: sub $0xc,%esp ffff5708: sub $0xfef04e00,%ecx ffff570e: test %ecx,%ecx ffff5710: jle ffff571e <bootblock_main_with_timestamp.constprop.1+0x1e> ffff5712: push %ecx ffff5713: push %ecx ffff5714: push %edx ffff5715: push %eax ffff5716: call ffff626a <timestamp_init> ffff571b: add $0x10,%esp ffff571e: call ffff6350 <bootblock_soc_early_init> ffff5723: call ffff56ff <bootblock_mainboard_early_init> ffff5728: call ffff4b80 <console_init> ffff572d: call ffff45e9 <exception_init> ffff5732: call ffff636f <bootblock_soc_init> ffff5737: call ffff631e <bootblock_mainboard_init> ffff573c: add $0xc,%esp ffff573f: jmp ffff5aec <run_romstage>
ffff5744 <bootblock_main_with_basetime>: ffff5744: mov 0x4(%esp),%eax ffff5748: mov 0x8(%esp),%edx ffff574c: jmp ffff5700 <bootblock_main_with_timestamp.constprop.1>