Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47988 )
Change subject: soc/intel/common/dmi: Add DMI driver support ......................................................................
Patch Set 5:
(5 comments)
https://review.coreboot.org/c/coreboot/+/47988/4/src/soc/intel/common/block/... File src/soc/intel/common/block/dmi/dmi.c:
https://review.coreboot.org/c/coreboot/+/47988/4/src/soc/intel/common/block/... PS4, Line 8:
nit: Generally, we use tabs to align all the macros.
Done
https://review.coreboot.org/c/coreboot/+/47988/4/src/soc/intel/common/block/... PS4, Line 8: /* 3 GPMR registers */
Comment can be dropped. Not much helpful.
Done
https://review.coreboot.org/c/coreboot/+/47988/4/src/soc/intel/common/block/... PS4, Line 10: *
spaces around *
Done
https://review.coreboot.org/c/coreboot/+/47988/4/src/soc/intel/common/block/... PS4, Line 15: *
spaces around *
Done
https://review.coreboot.org/c/coreboot/+/47988/4/src/soc/intel/common/block/... PS4, Line 56: base + size - 1
We might have to be careful about not overflowing here. […]
Done