Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44750 )
Change subject: ec/hp/kbc1126: Wait a longer time after the first command ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44750/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44750/2//COMMIT_MSG@10 PS2, Line 10: EliteBook 8470p (because the fan control command was not sent). How did you determine the timeout value? Trail and error?
https://review.coreboot.org/c/coreboot/+/44750/2/src/ec/hp/kbc1126/ec.c File src/ec/hp/kbc1126/ec.c:
https://review.coreboot.org/c/coreboot/+/44750/2/src/ec/hp/kbc1126/ec.c@121 PS2, Line 121: int timeout = 0x17ff; Please add a comment how many ms this is.
https://review.coreboot.org/c/coreboot/+/44750/2/src/ec/hp/kbc1126/ec.c@123 PS2, Line 123: udelay(10); Please use the stopwatch framework, and print he actual time spent.