Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39731 )
Change subject: [WIP] drivers/intel/gma: Provide default definition for integrated panel ......................................................................
Patch Set 4:
if the goal with this patch is to simplify drivers_intel_gma_displays_ssdt_generate(), why not just drop ndid/did[] from i915_gpu_controller_info struct and just have the ssdt generator produce a single entry for LCD0, since all the data for it is known and static? Dragging i915_gpu_controller_info forward to newer platforms when we have a single fixed did entry and the rest of the fields aren't relevant/used for the platform seems unnecessary. Platforms can simply call drivers_intel_gma_displays_ssdt_generate(void) if a given board has an internal panel driven by the IGD.
It's not more or less relevant for newer platforms than for older ones. IMO, we either completely drop it, or we should always use it. With the new macro, it's a single line per mainboard, and it won't get less than that, I guess.