Attention is currently required from: Tarun Tuli, Kangheui Won, Reka Norman, Tim Wawrzynczak, Tyler Wang, Nick Vaccaro.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68660 )
Change subject: mb/google/nissa/var/craask: Add wifi sar table
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/brya/variants/craask/variants.c:
https://review.coreboot.org/c/coreboot/+/68660/comment/026829d9_3216b7e9
PS6, Line 8: enum {
We don't really want to use SKU IDs in coreboot. […]
We have FW config for it. https://chrome-internal-review.googlesource.com/c/chromeos/project/nissa/cra...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68660
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c92f0ab53ece12a97068f09241e5298909116aa
Gerrit-Change-Number: 68660
Gerrit-PatchSet: 6
Gerrit-Owner: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cathy Chen
cathy_chen@quanta.corp-partner.google.com
Gerrit-CC: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Fri, 04 Nov 2022 01:46:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Gerrit-MessageType: comment