Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37539 )
Change subject: drivers/i2c/rt5663/: fix missing header include ......................................................................
Patch Set 1:
(2 comments)
Generally, relying on indirect includes is discouraged (unless a header file is specifically crafted to provide another file's definitions).
https://review.coreboot.org/c/coreboot/+/37539/1/src/drivers/i2c/rt5663/chip... File src/drivers/i2c/rt5663/chip.h:
https://review.coreboot.org/c/coreboot/+/37539/1/src/drivers/i2c/rt5663/chip... PS1, Line 18: #include <stdint.h>
because it's already included in acpi_device. […]
But it's used independently from ACPI. e.g. if one would remove the struct acpi* fields below, they shouldn't have to add the include back. So it should stay.
https://review.coreboot.org/c/coreboot/+/37539/1/src/drivers/i2c/rt5663/rt56... File src/drivers/i2c/rt5663/rt5663.c:
https://review.coreboot.org/c/coreboot/+/37539/1/src/drivers/i2c/rt5663/rt56... PS1, Line 15: #include <arch/acpi_device.h> Same here, if one would remove the fields in `chip.h`...