Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30724 )
Change subject: drivers/generic/adau7002: Add wakeup-delay-ms property ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/30724/2/src/drivers/generic/adau7002/adau700... File src/drivers/generic/adau7002/adau7002.c:
https://review.coreboot.org/#/c/30724/2/src/drivers/generic/adau7002/adau700... PS2, Line 35: !dev->chip_info
Or... […]
dev_chip_info shouldn't ever be null. If the wakeup_delay value isn't set in devicetree, we'll still have the chip_info structure in the static devicetree, and wakeup_delay will be 0.
https://review.coreboot.org/#/c/30724/2/src/drivers/generic/adau7002/chip.h File src/drivers/generic/adau7002/chip.h:
https://review.coreboot.org/#/c/30724/2/src/drivers/generic/adau7002/chip.h@... PS2, Line 21: unsigned please change to 'unsigned int'