Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41899 )
Change subject: device/xhci: Add an xhci driver to enumerate capabilities
......................................................................
Uploaded patch set 2.
(3 comments)
https://review.coreboot.org/c/coreboot/+/41899/1/src/device/xhci.c
File src/device/xhci.c:
https://review.coreboot.org/c/coreboot/+/41899/1/src/device/xhci.c@42
PS1, Line 42: ext_caps_offset = read16(bar + XHCI_HCCPARAMS1_XECP);
I guess I can make it print an error and return CB_ERR.
Done
https://review.coreboot.org/c/coreboot/+/41899/1/src/device/xhci.c@66
PS1, Line 66: ext_caps_offset = 0;
So this basically terminates the while loop? Why not use `break`?
Done
https://review.coreboot.org/c/coreboot/+/41899/1/src/device/xhci.c@68
PS1, Line 68:
I can add an xhci_print_supported_protocol that the callbacks can call if they want to debug.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41899
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3065c3fffad01b5378a55cfe904f971079b13d0f
Gerrit-Change-Number: 41899
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 01 Jun 2020 20:12:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment