[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede: Add camera support for WDoo

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39360 )

Change subject: mb/google/dedede: Add camera support for WDoo
......................................................................

Patch Set 15:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39360/15/src/mainboard/google/deded... 
File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39360/15/src/mainboard/google/deded... 
PS15, Line 209: /* E6  : GPP_E6/IMGCLKOUT_3 */
> Configure this strap?

No need to configure the straps. I learnt that the hardware straps are sampled before x86 is taken out of reset. So leave it as NC.

https://review.coreboot.org/c/coreboot/+/39360/15/src/mainboard/google/deded... 
PS15, Line 221: /* E12 : GPP_E12/IMGCLKOUT_4 */
> Configure this strap?

Same response as above. No need to configure the straps.