Attention is currently required from: Angel Pons, Jan Dabros, Duncan Laurie. jacz@semihalf.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50910 )
Change subject: acpi/acpigen.h: Add more intuitive AML package closing functions ......................................................................
Patch Set 1:
(4 comments)
File src/include/acpi/acpigen.h:
https://review.coreboot.org/c/coreboot/+/50910/comment/450778c5_5a9b8f0e PS1, Line 331: inline void acpigen_write_method_end(void)
Since `acpigen_write_method_serialized` is also a method, I'd place `acpigen_write_method_end` below […]
Sure :)
https://review.coreboot.org/c/coreboot/+/50910/comment/c98b0561_76d2c7de PS1, Line 404: inline void acpigen_write_if_end(void)
Same here
Done
https://review.coreboot.org/c/coreboot/+/50910/comment/f227dde0_716b5ed4 PS1, Line 412: void acpigen_write_else(void);
Looks like all calls to `acpigen_write_else` are preceded by an `acpigen_pop_len` call. […]
It would require a lot of changes to be applied to existing code. Should we do this?
https://review.coreboot.org/c/coreboot/+/50910/comment/7583d0c0_ff4aba52 PS1, Line 413: inline void acpigen_write_else_end(void)
IMHO, I'd also close else-blocks with `acpigen_write_if_end`, especially if implementing the suggest […]
For me it looks good. Like #endif in C preprocessor macros. Should I remove `acpigen_else_end()` then?