Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37026 )
Change subject: vendorcode/siemens/hwilib: Drop CAR_GLOBAL_MIGRATION ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37026/5/src/vendorcode/siemens/hwil... File src/vendorcode/siemens/hwilib/hwilib.c:
https://review.coreboot.org/c/coreboot/+/37026/5/src/vendorcode/siemens/hwil... PS5, Line 479: (char *)¤t_hwi current_hwi is an array of type const char. This should be enough here: if (!strncmp(current_hwi, hwi_filename, HWI_MAX_NAME_LEN)) {
https://review.coreboot.org/c/coreboot/+/37026/5/src/vendorcode/siemens/hwil... PS5, Line 546: strncpy((char *)¤t_hwi, hwi_filename, HWI_MAX_NAME_LEN); same here, no need for cast and the '&' operator.