Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44060 )
Change subject: soc/intel/{icl.tgl,jsl}: Remove SMRAM register programming
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44060/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44060/1//COMMIT_MSG@7
PS1, Line 7: soc/intel/{icl.tgl,jsl}: Remove SMRAM register programming
This register was not used to lock the SMRAM RAM rather only controlled the access to range specifie […]
Angel, can this be marked resolved? any opens?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44060
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f581b90ea99012980f439a7914e8d901585b004
Gerrit-Change-Number: 44060
Gerrit-PatchSet: 3
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 05 Aug 2020 06:56:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Gerrit-MessageType: comment