Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47010 )
Change subject: mb/google/dedede/var/drawcia: Probe and enable DPTF configuration ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/47010/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47010/1//COMMIT_MSG@11 PS1, Line 11: board version
May be the commit message is not entirely accurate. […]
Done
https://review.coreboot.org/c/coreboot/+/47010/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/variant.c:
https://review.coreboot.org/c/coreboot/+/47010/1/src/mainboard/google/dedede... PS1, Line 27: DPTF_PASSIVE
Yes based on the available data.
Done
https://review.coreboot.org/c/coreboot/+/47010/1/src/mainboard/google/dedede... PS1, Line 33: board_ver == 1
I like that idea. We should be able to probe based on the clamshell or convertible FW_CONFIG bit. […]
Done
https://review.coreboot.org/c/coreboot/+/47010/1/src/mainboard/google/dedede... PS1, Line 33: if (!google_chromeec_get_board_version(&board_ver) && board_ver == 1) : memcpy(&cfg->policies.passive[DPTF_CHARGER], &charger_policy, : sizeof(charger_policy));
With the suggestion from Furquan, I think I may not need this approach. […]
Ack