Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44751 )
Change subject: soc/amd/picasso: copy local info to transfer buf ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/44751/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44751/2//COMMIT_MSG@10 PS2, Line 10: 0c12abe
Please prepend it with *commit*, and maybe use an eight or ten digit hash, so Gerrit marks it up as […]
Thanks, I was wondering why gerrit doesn't make a link.
https://review.coreboot.org/c/coreboot/+/44751/2//COMMIT_MSG@13 PS2, Line 13: varaible
variable
Done
https://review.coreboot.org/c/coreboot/+/44751/2//COMMIT_MSG@13 PS2, Line 13: it as local varaible and didn't put data into the region.
What problem did it cause?
Done
https://review.coreboot.org/c/coreboot/+/44751/2/src/soc/amd/picasso/psp_ver... File src/soc/amd/picasso/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/44751/2/src/soc/amd/picasso/psp_ver... PS2, Line 143: struct transfer_info_struct buffer_info = {0};
How about: […]
That and memset for zeroing will also work but I guess it's basically same. Is there any additional benefits?