Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39529 )
Change subject: src/mb/intel/tglrvp: Update camera ACPI configuration
......................................................................
Patch Set 5:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39529/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39529/5//COMMIT_MSG@9
PS5, Line 9: to make closer
to make *it* closer?
https://review.coreboot.org/c/coreboot/+/39529/5//COMMIT_MSG@9
PS5, Line 9: sensor data sheet
Please add the name and revision.
https://review.coreboot.org/c/coreboot/+/39529/5//COMMIT_MSG@10
PS5, Line 10: pin
pins?
https://review.coreboot.org/c/coreboot/+/39529/5//COMMIT_MSG@12
PS5, Line 12: * Clean up format
Clean-ups should be in separate commits.
https://review.coreboot.org/c/coreboot/+/39529/5//COMMIT_MSG@17
PS5, Line 17: capture images.
Before it wasn’t possible?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39529
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic11a36f1f82fe425c1a5796847ce020007064403
Gerrit-Change-Number: 39529
Gerrit-PatchSet: 5
Gerrit-Owner: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 14 Mar 2020 16:13:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment