Attention is currently required from: Cliff Huang, Martin Roth, Tim Wawrzynczak, Rizwan Qureshi, Sridhar Siricilla, Bernardo Perez Priego, Andrew McRae. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55503 )
Change subject: util/cse_serger: Add a new tool for stitching CSE components ......................................................................
Patch Set 13: Verified-1
(36 comments)
File util/cbfstool/bpdt_formats/subpart_entry_1.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/fb40bee4_53784bf9 PS13, Line 13: #define SUBPART_COMPRESSED(x) (((x) >> SUBPART_COMPRESSED_SHIFT) & SUBPART_COMPRESSED_MASK) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/5d71de18_e39dea7e PS13, Line 33: e->name, SUBPART_OFFSET(e->offset_bytes), SUBPART_COMPRESSED(e->offset_bytes) ? 'Y' : 'N', line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/9d624aa0_c29fb810 PS13, Line 44: for (size_t i = 0; i < count; i++) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/628d285e_a9b4145f PS13, Line 48: printf("%-25s%-25s%-25s%-25s%-25s%-25s\n", "Entry #", "Name", "Offset", "Huffman Compressed?", line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/89286cdd_732f5058 PS13, Line 54: for (size_t i = 0; i < count; i++) { braces {} are not necessary for single statement blocks
File util/cbfstool/cse_serger.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/f201d45c_4dc22cbb PS13, Line 51: bool (*match_version)(const struct buffer *); function definition argument 'const struct buffer *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/bc105991_ccefbd61 PS13, Line 54: void (*print_hdr)(const bpdt_hdr_ptr); function definition argument 'const bpdt_hdr_ptr' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/3dc4539e_f7b68a71 PS13, Line 55: bpdt_hdr_ptr (*read_hdr)(struct buffer *); function definition argument 'struct buffer *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/62956685_049fd38c PS13, Line 56: int (*write_hdr)(struct buffer *, const bpdt_hdr_ptr); function definition argument 'struct buffer *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/c5f30215_70928645 PS13, Line 56: int (*write_hdr)(struct buffer *, const bpdt_hdr_ptr); function definition argument 'const bpdt_hdr_ptr' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/b5cb8e99_bb8ab645 PS13, Line 58: size_t (*get_entry_count)(const bpdt_hdr_ptr); function definition argument 'const bpdt_hdr_ptr' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/fa7eef8d_2de3faa4 PS13, Line 59: void (*inc_entry_count)(bpdt_hdr_ptr); function definition argument 'bpdt_hdr_ptr' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/88d7160b_615c53d0 PS13, Line 61: cse_layout_ptr (*create_layout)(const struct cse_layout_regions *); function definition argument 'const struct cse_layout_regions *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/991ee561_ff6c0695 PS13, Line 62: void (*print_layout)(const cse_layout_ptr); function definition argument 'const cse_layout_ptr' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/cbe54d2d_72fe5f8c PS13, Line 63: cse_layout_ptr (*read_layout)(struct buffer *); function definition argument 'struct buffer *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/adc1fb44_27cdcb6f PS13, Line 64: int (*write_layout)(struct buffer *, const cse_layout_ptr); function definition argument 'struct buffer *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/0919ad02_34159f09 PS13, Line 64: int (*write_layout)(struct buffer *, const cse_layout_ptr); function definition argument 'const cse_layout_ptr' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/0e566baa_ae29e5c9 PS13, Line 66: void (*update_checksum)(bpdt_hdr_ptr, struct bpdt_entry *); function definition argument 'bpdt_hdr_ptr' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/133329de_66e0d67c PS13, Line 66: void (*update_checksum)(bpdt_hdr_ptr, struct bpdt_entry *); function definition argument 'struct bpdt_entry *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/60ddb942_d47f528f PS13, Line 67: bool (*validate_checksum)(bpdt_hdr_ptr, struct bpdt_entry *); function definition argument 'bpdt_hdr_ptr' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/a25d5392_cd198de4 PS13, Line 67: bool (*validate_checksum)(bpdt_hdr_ptr, struct bpdt_entry *); function definition argument 'struct bpdt_entry *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/96596ce8_f0edef69 PS13, Line 74: void *(*read)(struct buffer *); function definition argument 'struct buffer *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/3991016c_cd497d02 PS13, Line 75: void (*print)(const void *); function definition argument 'const void *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/abfee652_a1bb7b18 PS13, Line 76: size_t (*get_entry_count)(const void *); function definition argument 'const void *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/2991dd8c_351940a3 PS13, Line 77: void (*free)(void *); function definition argument 'void *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/201f4405_86082ac8 PS13, Line 81: void (*print)(struct buffer *, size_t); function definition argument 'struct buffer *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/f51cc703_5deea3e4 PS13, Line 81: void (*print)(struct buffer *, size_t); function definition argument 'size_t' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/cc7721c0_95665b08 PS13, Line 92: void read_member(struct buffer *, void *, size_t); function definition argument 'struct buffer *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/c6cee1a9_0e4a071c PS13, Line 92: void read_member(struct buffer *, void *, size_t); function definition argument 'void *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/617ac54e_e123bc08 PS13, Line 92: void read_member(struct buffer *, void *, size_t); function definition argument 'size_t' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/bd800985_2c762512 PS13, Line 93: void write_member(struct buffer *, void *, size_t); function definition argument 'struct buffer *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/47afc3ad_831c74aa PS13, Line 93: void write_member(struct buffer *, void *, size_t); function definition argument 'void *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/6bcf67a0_8c57b094 PS13, Line 93: void write_member(struct buffer *, void *, size_t); function definition argument 'size_t' should also have an identifier name
File util/cbfstool/cse_serger.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/aeae5805_1a5d7162 PS13, Line 272: ERROR("Part(%d) exceeds file size. Part offset=0x%x, Part size = 0x%x, File size = 0x%zx\n", line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/a42cd298_79c51b78 PS13, Line 631: if(params.output_dir && (stat(params.output_dir, &sb) == -1)) { space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129904): https://review.coreboot.org/c/coreboot/+/55503/comment/7644a162_2a42b25d PS13, Line 923: if (c < LONGOPT_START) { braces {} are not necessary for any arm of this statement