[coreboot-gerrit] Change in coreboot[master]: mb/google/hatch: Create palkia variant

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38860 )

Change subject: mb/google/hatch: Create palkia variant
......................................................................

Patch Set 14:

(6 comments)

https://review.coreboot.org/c/coreboot/+/38860/14/src/mainboard/google/hatch... 
File src/mainboard/google/hatch/variants/palkia/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/38860/14/src/mainboard/google/hatch... 
PS14, Line 8: PchSerialIoIndexI2C2
Add I2C3 and mark it disabled?

https://review.coreboot.org/c/coreboot/+/38860/14/src/mainboard/google/hatch... 
PS14, Line 82: 3.2
Should this be in a ACPI_PLD_GROUP with its USB2 pair?

https://review.coreboot.org/c/coreboot/+/38860/14/src/mainboard/google/hatch... 
PS14, Line 110: ELAN Touchscreen
This looks like it is the USI interface, can you add that to the name?

https://review.coreboot.org/c/coreboot/+/38860/14/src/mainboard/google/hatch... 
PS14, Line 119: stop_gpio
is there any issue having both devices declare the same stop GPIO?

https://review.coreboot.org/c/coreboot/+/38860/14/src/mainboard/google/hatch... 
PS14, Line 181: 		device pci 1e.3 off
missing "end" here

https://review.coreboot.org/c/coreboot/+/38860/14/src/mainboard/google/hatch... 
PS14, Line 188: HDA
I2S