John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38165 )
Change subject: soc/intel/tigerlake: Enable VT-d and generate DMAR ACPI table ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38165/10/src/soc/intel/tigerlake/ac... File src/soc/intel/tigerlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/38165/10/src/soc/intel/tigerlake/ac... PS10, Line 198: struct device *const
did you mean […]
Ack
https://review.coreboot.org/c/coreboot/+/38165/10/src/soc/intel/tigerlake/ac... PS10, Line 243: 4
do we have a constant for the number of TCSS ports? […]
Ack by adding MAX_TBT_PCIE_PORT into /include/soc/systemagent.h