Jingle Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43005 )
Change subject: mb/ocp/deltalake: Send OEM IPMI command for CMOS clear on RTC failure ......................................................................
Patch Set 12:
(5 comments)
https://review.coreboot.org/c/coreboot/+/43005/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43005/6//COMMIT_MSG@11 PS6, Line 11: This is to let the payload (LinuxBoot) do some handling.
In payload, […]
Done
https://review.coreboot.org/c/coreboot/+/43005/6//COMMIT_MSG@13 PS6, Line 13: Tested on OCP Delta Lake
Remove RTC battery.
Done
https://review.coreboot.org/c/coreboot/+/43005/6/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/ipmi.h:
https://review.coreboot.org/c/coreboot/+/43005/6/src/mainboard/ocp/deltalake... PS6, Line 42: uint8_t boot_dev4;
It’s an OEM defined IPMI command structure, […]
Done
https://review.coreboot.org/c/coreboot/+/43005/2/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/ipmi.h:
https://review.coreboot.org/c/coreboot/+/43005/2/src/mainboard/ocp/deltalake... PS2, Line 12: #define IPMI_OEM_SET_BIOS_BOOT_ORDER 0x52 : #define IPMI_OEM_GET_BIOS_BOOT_ORDER 0x53
Please align with line 11, they are all belong to NETFN_OEM.
Done
https://review.coreboot.org/c/coreboot/+/43005/2/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/ipmi.c:
https://review.coreboot.org/c/coreboot/+/43005/2/src/mainboard/ocp/deltalake... PS2, Line 135:
remove space.
Done