Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39837 )
Change subject: mb/emulation/qemu-q35: Enable CHROMEOS as an option ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39837/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39837/1//COMMIT_MSG@15 PS1, Line 15: kernel driver with drm atomic support) but it does work with virtio.
Sorry for being ignorant. […]
qemu has a number of different options for the -vga argument, but what is selected needs to match in both coreboot and the kernel.
In this case native init only works with drm-bochs (-vga std) which itself does not work with chrome. Instead using drm-virtio (-vga virtio) does work with chrome.
I had hoped that the recent addition of DRM atomic support to the bochs driver would help, but I still get a GPU watchdog from chrome.
https://review.coreboot.org/c/coreboot/+/39837/1//COMMIT_MSG@19 PS1, Line 19:
Please mention, that an FMAP is needed, and how you run QEMU with virtio.
Done
https://review.coreboot.org/c/coreboot/+/39837/1/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-q35/chromeos.c:
https://review.coreboot.org/c/coreboot/+/39837/1/src/mainboard/emulation/qem... PS1, Line 22: int get_write_protect_state(void)
`bool is_write_protected(void)`
This function is defined and used elsewhere so I can't really change it here.
https://review.coreboot.org/c/coreboot/+/39837/1/src/mainboard/emulation/qem... PS1, Line 31: int get_recovery_mode_switch(void)
Make it return bool, and name it: `is_recovery_mode_enabled()?
same as above. these functions are already defined and used by chromeos code.