Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25345 )
Change subject: soc/amd/stoneyridge: Generate SPCR table
......................................................................
Patch Set 6:
(3 comments)
Sorry for another round of questions. The source LGTM though.
https://review.coreboot.org/#/c/25345/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/25345/6//COMMIT_MSG@11
PS6, Line 11: custom input clock
maybe a nit - is this comment left over from a previews version of the patch? or did I miss the clock somewhere?
https://review.coreboot.org/#/c/25345/6//COMMIT_MSG@11
PS6, Line 11: of of
nit
https://review.coreboot.org/#/c/25345/6/src/soc/amd/stoneyridge/uart.c
File src/soc/amd/stoneyridge/uart.c:
https://review.coreboot.org/#/c/25345/6/src/soc/amd/stoneyridge/uart.c@41
PS6, Line 41: AMDCZ
The glib answer is to make this work: https://lkml. […]
thanks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25345
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc98bcf4f8c070b8002bcc795254b19f928c741b
Gerrit-Change-Number: 25345
Gerrit-PatchSet: 6
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Thu, 13 Jun 2019 02:16:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Daniel Kurtz
djkurtz@google.com
Gerrit-MessageType: comment