Attention is currently required from: Shelley Chen, Taniya Das, Venkat Thogaru, Julius Werner, Sudheer Amrabadi.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68384 )
Change subject: soc/qualcomm/sc7280: Add socinfo_pro_part() function in coreboot ......................................................................
Patch Set 9:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68384/comment/1e7338bb_0dfa9207 PS9, Line 7: Please use one space.
https://review.coreboot.org/c/coreboot/+/68384/comment/74ee7b34_8d8d4b29 PS9, Line 7: Add socinfo_pro_part() function in : coreboot Maybe: Add function to differentiate between PRO and NON_PRO SKUs
https://review.coreboot.org/c/coreboot/+/68384/comment/ab9f558c_0b093dca PS9, Line 8: coreboot Please just use one line for the summary [1].
[1]: https://cbea.ms/git-commit/
https://review.coreboot.org/c/coreboot/+/68384/comment/3b9caa28_8aa36273 PS9, Line 10: Please use exactly one space.
https://review.coreboot.org/c/coreboot/+/68384/comment/9f6fcd8e_354db989 PS9, Line 10: The API socinfo_pro_part is added to help to differentiate : between PRO and NON_PRO SKUs. Returns 1 for Pro : and 0 for NON_PRO SKUs. Please reflow for 72 characters per line.
https://review.coreboot.org/c/coreboot/+/68384/comment/141fef69_fdece0e8 PS9, Line 15: Validate boards are detected correctly on PRO : and NON_PRO SKUs Ditto.
Patchset:
PS9: The commit seems to do more changes than documented in the commit message.