Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39886 )
Change subject: soc/amd/picasso: Add helper functions for finding SOC type ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39886/1/src/soc/amd/picasso/soc_uti... File src/soc/amd/picasso/soc_util.c:
https://review.coreboot.org/c/coreboot/+/39886/1/src/soc/amd/picasso/soc_uti... PS1, Line 26: RAVEN2_CPUID
So internally we have a additional check for dali_3250U […]
i asked a question in the corresponding ticket, since it's not 100% clear to me if that was just a temporary workaround for some engineering sample or if that is for a chip that ends up being used in production units. so if that's necessary, i'll add that as a follow-up. didn't include that yet, since it seemed a bit odd to me