Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42064 )
Change subject: soc/amd/picasso: Split I2c implementation for psp_verstage
......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42064/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42064/5//COMMIT_MSG@7
PS5, Line 7: soc/amd/picasso: Split I2c implementation for psp_verstage
i2c or I2C. First is more readable to my eyes.
Done
https://review.coreboot.org/c/coreboot/+/42064/9/src/soc/amd/picasso/Makefil...
File src/soc/amd/picasso/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42064/9/src/soc/amd/picasso/Makefil...
PS9, Line 48: verstage-y
Could make this verstage_arm-y, and verstage_x86-y
I'm going to look at recombining these into a single file in a follow-on patch. If I can't, i'll update this to be cleaner then.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42064
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45380e0c61e1bb7a94a96630e5867b7ffca0909c
Gerrit-Change-Number: 42064
Gerrit-PatchSet: 9
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Jun 2020 22:11:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment