Attention is currently required from: Furquan Shaikh, Martin Roth, Duncan Laurie.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52747 )
Change subject: util/sconfig: Add support for discontiguous FW_CONFIG fields
......................................................................
Patch Set 5:
(3 comments)
File Documentation/lib/fw_config.md:
https://review.coreboot.org/c/coreboot/+/52747/comment/deeb53bf_ef32fbe3
PS4, Line 134: 2
should this be end-bit1? (to be consistent with the first set of start-bit0/end-bit0
Oops
https://review.coreboot.org/c/coreboot/+/52747/comment/a145de34_d4a70e8a
PS4, Line 139:
this is a tab when the others are spaces. […]
Done
https://review.coreboot.org/c/coreboot/+/52747/comment/bfe81eaf_5012f52c
PS4, Line 141:
remove this tab to align?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52747
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ed76706347ee9642198efc77139abdc3af1b8a6
Gerrit-Change-Number: 52747
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
duncan@iceblink.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Duncan Laurie
duncan@iceblink.org
Gerrit-Attention: Duncan Laurie
dlaurie@gmail.com
Gerrit-Comment-Date: Fri, 30 Apr 2021 19:00:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@gmail.com
Gerrit-MessageType: comment