build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39414 )
Change subject: [WIP] nb/intel/pineview: Clean up ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/c/coreboot/+/39414/2/src/northbridge/intel/pinev... File src/northbridge/intel/pineview/pineview.h:
https://review.coreboot.org/c/coreboot/+/39414/2/src/northbridge/intel/pinev... PS2, Line 123: #define EPBAR8(x) *((volatile u8 *)(DEFAULT_EPBAR + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39414/2/src/northbridge/intel/pinev... PS2, Line 131: #define DMIBAR8(x) *((volatile u8 *)(DEFAULT_DMIBAR + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39414/2/src/northbridge/intel/pinev... File src/northbridge/intel/pineview/raminit.c:
https://review.coreboot.org/c/coreboot/+/39414/2/src/northbridge/intel/pinev... PS2, Line 1224: #define TABLE static const Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39414/2/src/northbridge/intel/pinev... PS2, Line 1227: #define FOR_EACH_RCOMP_GROUP for (i = 0; i < 7; i++) if (i != 1) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39414/2/src/northbridge/intel/pinev... PS2, Line 2052: if (minlanecoarse > lanecoarse[lane]) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/39414/2/src/northbridge/intel/pinev... PS2, Line 2582: const char *boot_str[] = {"Normal", "Reset", "Resume"}; char * array declaration might be better as static const