You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32263 )
Change subject: google/kukui: Include panel identifier (LCM ID) into SKU ID
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32263/5/src/mainboard/google/kukui/boardid.c
File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/#/c/32263/5/src/mainboard/google/kukui/boardid.c...
PS5, Line 33: static const int voltages_default[] = {
I thought about that, but then it's harder to choose ARRAY_SIZE. […]
Maybe something like
#define GET_INDEX(channel, table) get_index(channel, ARRAY_SIZE(table), table)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32263
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0c00bc8ce3c71c445c5c4561403ce8ef4dd5844
Gerrit-Change-Number: 32263
Gerrit-PatchSet: 5
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Apr 2019 06:09:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment