Attention is currently required from: Jason Glenesk, Matt DeVillier, Paul Menzel, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74249 )
Change subject: soc/amd/phoenix/Kconfig: Prevent changes to AMD_FWM_POSITION_INDEX ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74249/comment/ba37ed4d_52aa5c92 PS2, Line 10: to the only valid value and prevent mainboard overrides.
… by making the option non-user-configurable.
Done
File src/soc/amd/phoenix/Kconfig:
https://review.coreboot.org/c/coreboot/+/74249/comment/00c71a43_a21349bf PS2, Line 310: Typically this is calculated by the ROM size, but there may : be situations where you want to put the firmware directory : table in a different location. : 0: 512 KB - 0xFFFA0000 : 1: 1 MB - 0xFFF20000 : 2: 2 MB - 0xFFE20000 : 3: 4 MB - 0xFFC20000 : 4: 8 MB - 0xFF820000 : 5: 16 MB - 0xFF020000
Should this be updated too?
This is the common help text for that option for other AMD SOCs. The help is still accurate for what those values mean, it is just that all except index 5 are invalid on phoenix.