Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45755 )
Change subject: mb/google/zork: disable eMMC per FW_CONFIG for Morphius
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45755/2/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/morphius/variant.c:
https://review.coreboot.org/c/coreboot/+/45755/2/src/mainboard/google/zork/v...
PS2, Line 4: #include <device/device.h>
: #include <soc/pci_devs.h>
Probably not neded?
https://review.coreboot.org/c/coreboot/+/45755/2/src/mainboard/google/zork/v...
PS2, Line 6: #include <ec/google/chromeec/ec.h>
Not needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45755
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67d5d77ce3d827ae89b82529de59925f67eaf894
Gerrit-Change-Number: 45755
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 26 Sep 2020 13:35:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment