Attention is currently required from: Appukuttan V K, Arthur Heymans, Dinesh Gehlot, Lean Sheng Tan, Paul Menzel.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82102?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: Makefile.mk: Align romstage to page directory pointer requirements
......................................................................
Patch Set 2:
(1 comment)
File Makefile.mk:
https://review.coreboot.org/c/coreboot/+/82102/comment/d61386f8_79ee4b9a :
PS1, Line 1282: In the
: # future cbfstool should add XIP files proper and honor the alignment
: # requirements of the program segment.
Should we consider trying to do this instead of always fixing up this hardcoded value? cbfstool does run `convert()` before `locate()` nowadays (which I think might not have been the case when this was written), so it should be possible to decide the alignment in the XIP parsing step (based on the highest `phdr->p_align`).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82102?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I94e4a4209b7441ecb2966a1342c3d46625771bb8
Gerrit-Change-Number: 82102
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jincheng Li
jincheng.li@intel.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shuo Liu
shuo.liu@intel.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Tue, 30 Apr 2024 21:03:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment