Attention is currently required from: Hung-Te Lin, jason-ch chen.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74063 )
Change subject: soc/mediatek/mt8188: Add GPIO driving functions ......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74063/comment/afc1160a_c81e40e1 PS5, Line 10: This implementation is according to chapter 5.2 in MT8188 Functional Add a blank line between paragraphs.
File src/soc/mediatek/mt8188/gpio.c:
https://review.coreboot.org/c/coreboot/+/74063/comment/cc1530e8_6edc3a91 PS5, Line 20: spi_gpio_driving_info (Optional) Consider `bootblock_gpio_driving_info`.
https://review.coreboot.org/c/coreboot/+/74063/comment/61c5f4b8_625f7eba PS5, Line 211: GPIO_NUM With CB:74068 now returning NULL and returning zero from `gpio_driving_adv_info` are equivalent. Therefore we can save some memory by dropping `GPIO_NUM`.