Attention is currently required from: Patrick Rudolph.
Felix Held has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86539?usp=email )
Change subject: arch/x86/acpi_bert: Add spinlock ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: good catch! not sure if the spinlock is needed in the bert_errors_region function, since that only gets called from the acpi table generation code which only runs on the bsp i also wonder if it is sufficient to have a spinlock in the bert_allocate_storage and bert_storage_remaining function. i can only speak for the amd bert code, but there adding one error ends up calling bert_allocate_storage multiple times and when a second core starts to write a bert error while the first one doing that is in the middle of doing that, this might still result in corrupted data inside the bert table. sure, this is a very unlikely case, but if we ever run into that issue, that would be a pain to debug