[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Configure GPIOs again after FSP-S is done

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31250 )

Change subject: soc/intel/cannonlake: Configure GPIOs again after FSP-S is done
......................................................................

Patch Set 5:

(1 comment)

Patchset:

PS5:
> > Padcfg gets locked down by FSP anyways before any payload / OS starts.
>
> I think it is configurable using `PchUnlockGpioPads`

Ack. I wasn't aware that it's actually used.
> > Well, as already mentioned, see CB:45211. All these UPDs will change pad config.
>
> Oh okay. Since there was no follow-up change in that series, it was not clear how the missing special function pads were utilized at mainboard level.

Yeah, I have a patch locally, but never pushed it because I realized later, that we should configure the UPDs in any case because we won't know when Intel does more than pad config in the future with some of these UPDs :S