Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23027 )
Change subject: mb/solidrun/solidpc: Do initial commit ......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/23027/12/src/mainboard/solidrun/sol... File src/mainboard/solidrun/solidpc/com_init.c:
https://review.coreboot.org/c/coreboot/+/23027/12/src/mainboard/solidrun/sol... PS12, Line 26: : uint32_t *pad_config_reg; : : /* Enable the UART hardware for COM1. */ : pci_write_config32(PCI_DEV(0, LPC_DEV, 0), UART_CONT, 1); : : /* : * Set up the pads to select the UART function : * AD12 SW16(UART1_DATAIN/UART0_DATAIN) - Setting Mode 2 for UART0_RXD : * AD10 SW20(UART1_DATAOUT/UART0_DATAOUT) - Setting Mode 2 for UART0_TXD : */ : pad_config_reg = gpio_pad_config_reg(GP_SOUTHWEST, UART1_RXD_PAD); : write32(pad_config_reg, SET_PAD_MODE_SELECTION(PAD_CONFIG0_DEFAULT0, : M2)); : : pad_config_reg = gpio_pad_config_reg(GP_SOUTHWEST, UART1_TXD_PAD); : write32(pad_config_reg, SET_PAD_MODE_SELECTION(PAD_CONFIG0_DEFAULT0, : M2));
No braswell board in coreboot except SolidPC uses it, however I agree it can be moved out to soc/braswell
Both google/cyan and google/strago have the same code and the same meaningless Kconfig option ENABLE_BUILTIN_COM1. So it would make a lot of sense to move it there. However I don't think ENABLE_BUILTIN_COM1 is a good Kconfig. Pads should not be configured based on user selectable Kconfig options, so better call it MB_HAS_BUILTIN_COM1 or something like that.