build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39331 )
Change subject: src/*: Make PCI ID macro names shorter ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/c/coreboot/+/39331/2/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/39331/2/src/include/device/pci_ids.... PS2, Line 2044: #define PCI_VID_AKS 0x416c 'AKS' may be misspelled - perhaps 'ASK'?
https://review.coreboot.org/c/coreboot/+/39331/2/src/include/device/pci_ids.... PS2, Line 2045: #define PCI_DID_AKS_ALADDINCARD 0x0100 'AKS' may be misspelled - perhaps 'ASK'?
https://review.coreboot.org/c/coreboot/+/39331/2/src/include/device/pci_ids.... PS2, Line 2046: #define PCI_DID_AKS_CPC 0x0200 'AKS' may be misspelled - perhaps 'ASK'?
https://review.coreboot.org/c/coreboot/+/39331/2/src/soc/intel/skylake/vr_co... File src/soc/intel/skylake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/39331/2/src/soc/intel/skylake/vr_co... PS2, Line 229: (igd_id == PCI_DID_INTEL_KBL_GT3E_SULTM_2)) { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39331/2/src/southbridge/amd/agesa/h... File src/southbridge/amd/agesa/hudson/hudson.c:
https://review.coreboot.org/c/coreboot/+/39331/2/src/southbridge/amd/agesa/h... PS2, Line 80: else if (sd_device_id == PCI_DID_AMD_YANGTZE_SD) { else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/39331/2/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/hudson.c:
https://review.coreboot.org/c/coreboot/+/39331/2/src/southbridge/amd/pi/huds... PS2, Line 54: else if (sd_device_id == PCI_DID_AMD_YANGTZE_SD) { else should follow close brace '}'