Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42137 )
Change subject: mb/google/hatch: drop VBOOT_LID_SWITCH from hatch baseboard ......................................................................
mb/google/hatch: drop VBOOT_LID_SWITCH from hatch baseboard
Selecting VBOOT_LID_SWITCH under BOARD_GOOGLE_BASEBOARD_HATCH creates a requirement for VBOOT, and prevents building in the non-vboot/non-ChromeOS case. As this symbol is already selected by CHROMEOS below, there's no need for the baseboard (and only one of the two) to select it, so don't.
Change-Id: I060e82185997bce451648173dd97dd6a3d5d237f Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42137 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 46aa4d1..5821b76 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -3,7 +3,6 @@ def_bool n select BOARD_GOOGLE_HATCH_COMMON select SYSTEM_TYPE_LAPTOP - select VBOOT_LID_SWITCH
config BOARD_GOOGLE_BASEBOARD_PUFF def_bool n